(fix) multiply item weight_grams by quantity in bag total weight calc…#898
Open
gzor wants to merge 1 commit intomauriceboe:devfrom
Open
(fix) multiply item weight_grams by quantity in bag total weight calc…#898gzor wants to merge 1 commit intomauriceboe:devfrom
gzor wants to merge 1 commit intomauriceboe:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the quantity does not effect the total bag weight.
The data is already there, I would just need to change the calculation of the weight of the bag in the frontend.
Use case: User Marco adds lunches with a weight estimation per lunch, and can adjust the quantity for different trekking trips depending on how long the trek goes.
Related Issue or Discussion
discord link:
https://discord.com/channels/1488298068427411591/1496176614801670244
Type of Change
Checklist
devdevbranch, notmainI tested it locally (manual).
I tried to run the test, but they are failing on my machine... i am not sure if i did something wrong or if the tests in general are not up to date. It did not give me the impressions, that the failing tests are associated with my very small change though, therfore i think this is a problem with my local dev env.